Support Python 3 #2738
Merged
Support Python 3 #2738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmuesch
reviewed
Dec 12, 2018
| --hash=sha256:2b1876a60e32e24bed4c6d187898274de6409bbfa942bcbe3512efdf2aed0ec9 | ||
|
|
||
| python3-gearman==0.1.0 ; sys_platform != "win32" and python_version > "3.0" \ |
There was a problem hiding this comment.
Are we bumping the req in the root agent-req file now or when release happens?
There was a problem hiding this comment.
@nmuesch I bumped the requirements file, can you rereview
nmuesch
previously approved these changes
Dec 12, 2018
Codecov Report
@@ Coverage Diff @@
## master #2738 +/- ##
==========================================
- Coverage 84.7% 75.83% -8.87%
==========================================
Files 657 51 -606
Lines 37189 3398 -33791
Branches 4462 395 -4067
==========================================
- Hits 31501 2577 -28924
+ Misses 4378 718 -3660
+ Partials 1310 103 -1207 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This moves Gearmand to Python3. Python 3 support for the library is a new drop in replacement library: https://github.com/josiahmwalton/python3-gearman
We can use that, we just need to amend the requirements files and make the import conditional
Motivation
We need to move everything to python3
Review checklist
no-changeloglabel attachedAdditional Notes
Anything else we should know when reviewing?